-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/workflow failure #1250
Fix/workflow failure #1250
Conversation
Workaround for CI fails because ubuntu-latest version is 24.04 which doesn't support python 3.7. Signed-off-by: Thomas Darimont <[email protected]>
9ffa12c
to
4d2c212
Compare
@AssahBismarkabah tested your ci build fix on my fork: The ci build is green. There was one failure on the keycloak 23 build. After a re-run it was successful.
Can you re-run the failing ci jobs on you pr? |
Hi @bohmber , It seems to be successful. Can you review the PR so it can be merged and rebased with the other pending PRs? Thanks for your assistance :) |
@AssahBismarkabah What is the differences between this PR and this one #1246 ? I don't have enough karma that my review is enough. |
@AssahBismarkabah I don't know what has changed in the meantime. It could be something github internal. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @AssahBismarkabah. But i am unable to find the root cause for the previous failure and the custom attribute is populated locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fix ci failure and closes #1246Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR