-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: improves download and verify of ant binary #3752
base: master
Are you sure you want to change the base?
Conversation
@mahdipub linter failures |
by replacing `command: wget` with `get_url` module, it helps to support more systems. Also while running `GPG Signature verification` some systems (e.g old mac machines) have problem with wget while running `package_signature_verification.sh`. This change makes sure all systems will find wget in their `PATH`. Sigend-off-by: [email protected]
ab3560a
to
2b760af
Compare
Thanks, resolved. |
@@ -29,7 +29,9 @@ | |||
tags: ant | |||
|
|||
- name: Download Apache Ant binaries (macOS) and (Solaris) | |||
command: wget https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.5-bin.zip -O /tmp/apache-ant-1.10.5-bin.zip | |||
get_url: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in other scripts we're extracting that version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I did not get the question here. I just changed wget command
to get_url
module which help prevent wget not found error on some hosts. I did not touch version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, extracting 1.10.5 to a single const at the top (as it gets repeated)
by replacing
command: wget
withget_url
module, it helps to support more systems. Also while runningGPG Signature verification
some systems (e.g old mac machines) have problem with wget while runningpackage_signature_verification.sh
. This change makes sure all systems will find wget in theirPATH
.Sigend-off-by: [email protected]
Checklist