feat(addon/components/paper-input): converts to a glimmer component. #1312
+904
−261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
20 tasks
hero-davidm
approved these changes
Dec 4, 2024
matthewhartstonge
force-pushed
the
feature/glimmer-paper-switch
branch
from
b7e4167 to
289a44c
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-input
branch
from
3826ad3 to
9ed977b
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-switch
branch
from
289a44c to
78c3c36
Compare
matthewhartstonge
changed the base branch from
feature/glimmer-paper-switch
to
feature/glimmer-paper-tabs
matthewhartstonge
force-pushed
the
feature/glimmer-paper-input
branch
from
9ed977b to
608beeb
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-tabs
branch
from
71fcab7 to
ce40958
Compare
…lement is disabled.
…king the validity of a value/input element.
…ding` and `no-positive-tabindex` due to being user passthroughs.
matthewhartstonge
force-pushed
the
feature/glimmer-paper-input
branch
from
608beeb to
c128116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fun...
I've opted to migrate from the ValidationMixin by using an injectable
Validationclass.There are a couple more components that require this migration (paper-autocomplete and paper-select) so I'll make changes as required, or maybe make unique ones if required...
I'm pretty sure all places work on validating an input component, so we should be good 🎉
(The Validator now allows me to go back and fix the failing paper-form tests once migrating the other two dependants)