es6 args destructuring removed from public api on mocks #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #226
Even though the issue is fixed, there are still questions on whether
convertErrors
should be adapter specific. For example, someone using json-api, would expect errors as per spec:http://jsonapi.org/examples/#error-objects-multiple-errors
When with
DS.RESTAdapter
it's just{errors: {field: ['error 1', 'error 2']}}
Should we remove that option at all and do the conversion implicitly depending on what adapter is in use?