Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stylelint): addresses remaining stylelint violations #3359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 31, 2024

Description

This resolves our remaining stylelint issues around undefined tokens, rule order, unused values and color syntax.

  • Updates invalid color syntax from rgba(N, N, N, N) to rgba(N N N / N).
  • In cases of duplicate properties, preserves the property that would be applied given current code structure.
  • Updates misnamed tokens to use valid tokens (table/index.css).

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 7985ec2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@spectrum-css/infieldbutton Minor
@spectrum-css/logicbutton Minor
@spectrum-css/progressbar Minor
@spectrum-css/colorwheel Minor
@spectrum-css/assetcard Minor
@spectrum-css/colorarea Minor
@spectrum-css/calendar Minor
@spectrum-css/checkbox Minor
@spectrum-css/underlay Minor
@spectrum-css/stepper Minor
@spectrum-css/button Minor
@spectrum-css/modal Minor
@spectrum-css/radio Minor
@spectrum-css/table Minor
@spectrum-css/card Minor
@spectrum-css/site Minor
@spectrum-css/tokens Minor
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2024

🚀 Deployed on https://pr-3359--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 31, 2024

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🟢 ⬇ 4.71 KB (-0.11%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
calendar 19.14 KB 🟢 ⬇ 0.14 KB
card 20.24 KB 🟢 ⬇ 0.04 KB
infieldbutton 18.14 KB 🟢 ⬇ 0.01 KB
modal 5.38 KB 🟢 ⬇ 0.06 KB
radio 17.79 KB 🔴 ⬆ < 0.01 KB
stepper 19.71 KB 🟢 ⬇ 0.80 KB
table 46.84 KB 🟢 ⬇ 0.14 KB
underlay 3.17 KB 🟢 ⬇ 0.10 KB
tokens 410.85 KB 🟢 ⬇ 0.42 KB

Details

calendar

Filename Head Compared to base
index-base.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)
index-vars.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)
index.css 19.14 KB 🟢 ⬇ 0.14 KB (-0.69%)

card

Filename Head Compared to base
index-base.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)
index-vars.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)
index.css 20.24 KB 🟢 ⬇ 0.04 KB (-0.22%)

infieldbutton

Filename Head Compared to base
index-base.css 16.00 KB 🟢 ⬇ 0.01 KB (-0.04%)
index-theme.css 2.75 KB -
index-vars.css 18.14 KB 🟢 ⬇ 0.01 KB (-0.04%)
index.css 18.14 KB 🟢 ⬇ 0.01 KB (-0.04%)
themes/express.css 1.67 KB -
themes/spectrum.css 1.69 KB -

modal

Filename Head Compared to base
index-base.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)
index-vars.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)
index.css 5.38 KB 🟢 ⬇ 0.06 KB (-1.01%)

radio

Filename Head Compared to base
index-base.css 16.72 KB 🔴 ⬆ < 0.01 KB (0.02%)
index-theme.css 1.67 KB -
index-vars.css 17.79 KB 🔴 ⬆ < 0.01 KB (0.02%)
index.css 17.79 KB 🔴 ⬆ < 0.01 KB (0.02%)
themes/express.css 1.35 KB -
themes/spectrum.css 1.35 KB -

stepper

Filename Head Compared to base
index-base.css 16.48 KB 🟢 ⬇ 0.63 KB (-3.60%)
index-theme.css 3.85 KB 🟢 ⬇ 0.17 KB (-4.04%)
index-vars.css 19.71 KB 🟢 ⬇ 0.80 KB (-3.79%)
index.css 19.71 KB 🟢 ⬇ 0.80 KB (-3.79%)
themes/express.css 2.17 KB 🟢 ⬇ 0.17 KB (-6.95%)
themes/spectrum.css 2.29 KB -

table

Filename Head Compared to base
index-base.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)
index-vars.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)
index.css 46.84 KB 🟢 ⬇ 0.14 KB (-0.30%)

underlay

Filename Head Compared to base
index-base.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)
index-vars.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)
index.css 3.17 KB 🟢 ⬇ 0.10 KB (-2.90%)

tokens

Filename Head Compared to base
css/components/bridge/actionbutton.css 12.05 KB -
css/components/bridge/actiongroup.css 0.97 KB -
css/components/bridge/alertbanner.css 0.78 KB -
css/components/bridge/assetcard.css 0.76 KB -
css/components/bridge/button.css 35.45 KB -
css/components/bridge/checkbox.css 1.01 KB -
css/components/bridge/clearbutton.css 1.14 KB -
css/components/bridge/closebutton.css 1.06 KB -
css/components/bridge/combobox.css 1.11 KB -
css/components/bridge/datepicker.css 0.74 KB -
css/components/bridge/index.css 64.47 KB 🟢 ⬇ 0.25 KB (-0.38%)
css/components/bridge/infieldbutton.css 1.96 KB -
css/components/bridge/picker.css 1.87 KB -
css/components/bridge/pickerbutton.css 1.75 KB -
css/components/bridge/popover.css 0.73 KB -
css/components/bridge/radio.css 1.56 KB -
css/components/bridge/rating.css 1.00 KB -
css/components/bridge/search.css 2.03 KB -
css/components/bridge/slider.css 2.11 KB -
css/components/bridge/stepper.css 2.75 KB 🟢 ⬇ 0.25 KB (-8.15%)
css/components/bridge/switch.css 1.51 KB -
css/components/bridge/tabs.css 0.72 KB -
css/components/bridge/tag.css 3.51 KB -
css/components/bridge/textfield.css 1.20 KB -
css/components/bridge/toast.css 0.75 KB -
css/components/bridge/tooltip.css 0.77 KB -
css/components/express/actionbutton.css 8.96 KB -
css/components/express/actiongroup.css 0.93 KB -
css/components/express/alertbanner.css 0.77 KB -
css/components/express/assetcard.css 0.73 KB -
css/components/express/button.css 29.37 KB -
css/components/express/checkbox.css 0.95 KB -
css/components/express/clearbutton.css 1.03 KB -
css/components/express/closebutton.css 0.96 KB -
css/components/express/combobox.css 1.01 KB -
css/components/express/datepicker.css 0.73 KB -
css/components/express/index.css 51.77 KB 🟢 ⬇ 0.17 KB (-0.31%)
css/components/express/infieldbutton.css 1.67 KB -
css/components/express/picker.css 1.51 KB -
css/components/express/pickerbutton.css 1.51 KB -
css/components/express/popover.css 0.69 KB -
css/components/express/radio.css 1.35 KB -
css/components/express/rating.css 1.02 KB -
css/components/express/search.css 1.93 KB -
css/components/express/slider.css 1.78 KB -
css/components/express/stepper.css 2.17 KB 🟢 ⬇ 0.17 KB (-6.95%)
css/components/express/switch.css 1.29 KB -
css/components/express/tabs.css 0.72 KB -
css/components/express/tag.css 3.28 KB -
css/components/express/textfield.css 1.08 KB -
css/components/express/toast.css 0.75 KB -
css/components/express/tooltip.css 0.76 KB -
css/components/spectrum/actionbutton.css 9.15 KB -
css/components/spectrum/actiongroup.css 0.82 KB -
css/components/spectrum/alertbanner.css 0.77 KB -
css/components/spectrum/assetcard.css 0.72 KB -
css/components/spectrum/button.css 29.43 KB -
css/components/spectrum/checkbox.css 0.94 KB -
css/components/spectrum/clearbutton.css 1.00 KB -
css/components/spectrum/closebutton.css 0.95 KB -
css/components/spectrum/combobox.css 1.02 KB -
css/components/spectrum/datepicker.css 0.72 KB -
css/components/spectrum/index.css 52.13 KB -
css/components/spectrum/infieldbutton.css 1.69 KB -
css/components/spectrum/picker.css 1.60 KB -
css/components/spectrum/pickerbutton.css 1.47 KB -
css/components/spectrum/popover.css 0.72 KB -
css/components/spectrum/radio.css 1.35 KB -
css/components/spectrum/rating.css 1.01 KB -
css/components/spectrum/search.css 1.84 KB -
css/components/spectrum/slider.css 1.75 KB -
css/components/spectrum/stepper.css 2.29 KB -
css/components/spectrum/switch.css 1.28 KB -
css/components/spectrum/tabs.css 0.71 KB -
css/components/spectrum/tag.css 3.30 KB -
css/components/spectrum/textfield.css 1.08 KB -
css/components/spectrum/toast.css 0.75 KB -
css/components/spectrum/tooltip.css 0.76 KB -
css/dark-vars.css 25.19 KB -
css/darkest-vars.css 25.14 KB -
css/express/custom-large-vars.css 1.10 KB -
css/express/custom-medium-vars.css 1.08 KB -
css/express/custom-vars.css 0.67 KB -
css/express/dark-vars.css 1.10 KB -
css/express/darkest-vars.css 1.11 KB -
css/express/global-vars.css 3.02 KB -
css/express/index.css 9.86 KB -
css/express/large-vars.css 3.58 KB -
css/express/light-vars.css 1.14 KB -
css/express/medium-vars.css 3.56 KB -
css/global-vars.css 38.84 KB -
css/large-vars.css 25.07 KB -
css/light-vars.css 25.16 KB -
css/medium-vars.css 25.00 KB -
css/spectrum/custom-large-vars.css 5.17 KB -
css/spectrum/custom-medium-vars.css 5.42 KB -
css/spectrum/custom-vars.css 3.17 KB -
css/spectrum/dark-vars.css 4.38 KB -
css/spectrum/darkest-vars.css 4.38 KB -
css/spectrum/global-vars.css 5.90 KB -
css/spectrum/index.css 31.00 KB -
css/spectrum/large-vars.css 7.48 KB -
css/spectrum/light-vars.css 4.36 KB -
css/spectrum/medium-vars.css 7.71 KB -
index.css 201.61 KB -
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf self-assigned this Oct 31, 2024
@cdransf cdransf added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. ready-for-review run_vrt For use on PRs looking to kick off VRT labels Oct 31, 2024
@cdransf cdransf marked this pull request as ready for review October 31, 2024 21:49
@cdransf cdransf marked this pull request as draft October 31, 2024 21:57
@cdransf cdransf marked this pull request as ready for review October 31, 2024 22:07
@cdransf cdransf force-pushed the cdransf/stylelint-cleanup branch 2 times, most recently from 329f3ea to 0d2f0ae Compare November 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-3 M ~18-30hrs; moderate effort or complexity, several work days needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant