-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storybook): align typography elements for VRTs #3343
chore(storybook): align typography elements for VRTs #3343
Conversation
|
File metricsSummaryTotal size: 4.30 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-3343--spectrum-css.netlify.app |
9436a14
to
925f091
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just had one minor question. ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the same issue you just linked in your comment, but wanted to point it out. The color of the headings on some "Docs" pages was the only issue I saw.
925f091
to
232b3eb
Compare
232b3eb
to
00f560b
Compare
I see |
d9bf6b9
to
d7d05af
Compare
Good call-out @jawinn, updated it to |
d7d05af
to
be3640c
Compare
Description
Currently VRTs are leveraging the Typography element for the ignored headings. Although they use the "chromatic-ignore" class, this can cause layout issues when the line-height or font-size changes for those typographical elements, leading to unexpected VRT differences. This PR aims to reduce that risk by isolating type styles for VRT from the design system.
In order for the text color to respond to the background context without using a token value, we need to pass the context data through the Container down to the Heading. To this end I've added the context passthroughs in all the existing uses.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
To-do list