Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stylelint): remove container from at-rule-no-unknown #3340

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 28, 2024

Description

Removes container from at-rule-no-unknown at the exception is no longer necessary. @container

Validation steps

  1. Fetch the branch
  2. Add an @container declaration to a CSS file
  3. Restart stylelint
  4. Verify the rule isn't marked as a stylelint violation

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Oct 28, 2024
@cdransf cdransf self-assigned this Oct 28, 2024
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 47314fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 28, 2024

🚀 Deployed on https://pr-3340--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 28, 2024

File metrics

Summary

Total size: 4.30 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking good! To test it, I added an @container rule for breadcrumb, and didn't see any errors in the browser console, dev console, or in the Problems pane in VSCode. 👍

@cdransf cdransf merged commit fa59456 into main Oct 30, 2024
12 checks passed
@cdransf cdransf deleted the cdransf/stylelint-container branch October 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants