Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update external fixes #312

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 14, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
esmock 2.5.1 -> 2.5.4 age adoption passing confidence
junit-report-builder 3.0.1 -> 3.1.0 age adoption passing confidence
nock 13.3.3 -> 13.3.4 age adoption passing confidence

Release Notes

iambumblehead/esmock (esmock)

v2.5.4: call resolver with builtin moduleIds

Compare Source

This change affects custom resolvers, which are supported from v2.5.2. Per the spec, resolvers will be called with the builtin moduleIds, such as "node:path" and "fs"

v2.5.3: add support for custom resolver

Compare Source

This release adds support for custom using a custom resolver. Specifically, a yarn PnP resolver can be passed to esmock, so that yarn PnP moduleIds can be resolved.

const modulePnP = await esmock('../src/parent.js', {
  '../src/PnPchild.js' : () => ['a', 'b']
}, null, {
  resolver: pnpapi.resolveRequest
})

v2.5.2: lookup export type based on package.json type

Compare Source

This release updates the resolver to improve module resolution. See resolvewithplus tags v2.0.6 and v2.0.7.

Essentially, the resolver is updated to lookup the export type based on package.json type. For example, if package.json type is "module", the "import" definition is resolved, else if package.json type is undefined or "commonjs", the "require" definition is resolved. Previous versions of esmock usually reslved commonjs/require when those were defined and because most packages are published as commonjs, the issues resolved at this release likely did not affect anyone,

  • resolve "exports" before "main". The spec says: the "exports" field takes precedence over "main" in supported versions of Node.js. The updated resolver correctly returns "main" before "exports" (older resolver did not).
  • use package.json "type" to return "import" or "require". The older resolver did not read package.json type and returned incorrect "require" values for some packages. For example, if this inferno package where changed to use type "module", the older resolver would return "index.js" rather than "index.esm.js"
davidparsson/junit-report-builder (junit-report-builder)

v3.1.0

Compare Source

nock/nock (nock)

v13.3.4

Compare Source

Bug Fixes
  • typescript: support nock(new URL('https://example.test/')) (#​2526) (6987327)

Configuration

📅 Schedule: Branch creation - "after 2pm on Saturday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions
Copy link

This PR will trigger no release when merged.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #312 (2fdfb14) into main (2045c86) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          490       490           
=========================================
  Hits           490       490           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renovate renovate bot merged commit 4357d3e into main Oct 14, 2023
@renovate renovate bot deleted the renovate-external-fixes branch October 14, 2023 15:02
@trieloff
Copy link
Contributor

🎉 This PR is included in version 1.7.82 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant