Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine grained access control #322

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Fine grained access control #322

wants to merge 11 commits into from

Conversation

bosschaert
Copy link
Contributor

Description

Add fine-grained access control as documented here: https://github.com/adobe/da-live/wiki/Using-ACLs

Performance characteristics can be found here: https://da.live/sheet#/da-sites/da-status/bosschae/performance/benchtimings

To try it out go here: https://acl--da-live--adobe.aem.page/?da-admin=stage&da-collab=stage

Test URLs:

Main: https://main--da-live--adobe.hlx.live/
Branch: https://acl--da-live--adobe.aem.page/?da-admin=stage&da-collab=stage

Related Issue

Fixes: adobe/da-admin#107

How Has This Been Tested?

  • Tested with da-admin and da-collab
  • Many unit tests added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jan 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 7, 2025

Page Scores Audits Google
📱 /?da-admin=stage&da-collab=stage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?da-admin=stage&da-collab=stage PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert
Copy link
Contributor Author

The Playwright tests fail because playwright doesn't use da-collab and da-admin from stage. They pass when I run them locally and once adobe/da-collab#61 and adobe/da-admin#108 are merged they will pass here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine grained access control
2 participants