-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add IMS offline token validation #109
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 77.41% 77.78% +0.36%
==========================================
Files 38 38
Lines 1820 1886 +66
==========================================
+ Hits 1409 1467 +58
- Misses 411 419 +8 ☔ View full report in Codecov by Sentry. |
This is great. Couple questions / comments:
Really looking forward to this. |
They do not publish a schedule for this.
There are no linting errors. npm run lint
> [email protected] lint
> eslint . There are only codecov errors, because for some reason c8/lcov does not capture correctly the coverage data. Lines that I can see covered by tests if add
I believe that yes, it does. I used the library functionality that he suggested to cache the keys in KV for 24h and there is a cooldown period of not fetching keys from remote if too many requests come with tokens pointing to invalid keys. I asked for his review too. https://github.com/panva/jose/blob/main/docs/jwks/remote/variables/jwksCache.md |
Description
Add IMS offline token validation.
How Has This Been Tested?
Unit tests only.
Screenshots (if appropriate):
Types of changes
Checklist: