Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IMS service token generation plugin #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

honstar
Copy link
Member

@honstar honstar commented Jan 27, 2021

Support for IMS service token generation plugin

Description

Adds s2s (service-to-service) plugin to support service token generation. This is currently WIP, see #34 .

Related Issue

#34

Motivation and Context

Currently, the existing aio-lib-ims does not provide means to generate IMS service tokens for service-to-service integrations. The proposed change integrates that support via a plugin analogous to the @adobe/aio-lib-ims-jwt one.

How Has This Been Tested?

100% code coverage via unit tests (jest) of the plugin that is being integrated. I've also tested this locally and validated the resulting IMS service token in an API call to a service requiring such a service token.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- add s2s (service-to-service) plugin to support service token generation
@honstar
Copy link
Member Author

honstar commented Jan 27, 2021

fyi: @moritzraho @shazron @meryllblanchet

@meryllblanchet
Copy link
Contributor

Thanks for this great contribution @honstar !
@shazron @moritzraho could you have a look?

@moritzraho
Copy link
Member

@honstar sorry for the delay, and thanks again for the contribution, I will have a look on monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants