Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new State #149

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: use new State #149

wants to merge 1 commit into from

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Aug 22, 2024

Description

https://github.com/adobe/aio-lib-state/releases/tag/4.0.0

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb41343) to head (b90797e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          488       488           
  Branches        68        68           
=========================================
  Hits           488       488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moritzraho
Copy link
Member Author

Back to draft, need to check context has allowed chars
It should be a breaking change, as namespaces not in amsorg-project-workspace format are not allowed to use this.

@moritzraho moritzraho marked this pull request as draft August 29, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants