Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update docs for getAccessTokenByClientCredentials, other docs fixes #139

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 7, 2023

Motivation and Context

The new OAuth Server to Server credentials grant type call returns an expiry in seconds, not milliseconds, like the older API. This will clarify things in the docs.

Also, other doc warnings have been fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #139 (8879e2e) into master (8d2d62a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          488       488           
  Branches        68        68           
=========================================
  Hits           488       488           
Files Changed Coverage Δ
src/ValidationCache.js 100.00% <ø> (ø)
src/ims.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit d656acf into master Sep 8, 2023
7 checks passed
@shazron shazron deleted the story/ACNA-2526 branch September 8, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants