Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-22335] js parse error fix 2 #2828

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[SITES-22335] js parse error fix 2 #2828

merged 2 commits into from
Jul 31, 2024

Conversation

YahorC
Copy link
Contributor

@YahorC YahorC commented Jul 31, 2024

The ?. operator was included in ES2020, which is supported by Node 14 (released in April 2020). But we are currently using ES2015 (see content.xml)

Q                       A
Fixed Issues? SITES-22335
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@YahorC YahorC added this to the 2.26.0 milestone Jul 31, 2024
@YahorC YahorC requested a review from a team July 31, 2024 11:44
Copy link

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (681d1bf) to head (21b0844).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2828   +/-   ##
=========================================
  Coverage     87.21%   87.21%           
  Complexity     2690     2690           
=========================================
  Files           235      235           
  Lines          7173     7173           
  Branches       1096     1096           
=========================================
  Hits           6256     6256           
  Misses          363      363           
  Partials        554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YahorC YahorC merged commit 0c971e7 into main Jul 31, 2024
14 checks passed
@YahorC YahorC deleted the fix_js_parse_error_2 branch July 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants