Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated org.json dependency #2593

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Updated org.json dependency #2593

merged 7 commits into from
Dec 18, 2023

Conversation

vladbailescu
Copy link
Member

No description provided.

@@ -529,6 +529,11 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.adobe.granite.bundles</groupId>
<artifactId>json</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really deprecated, rather use JSON-P Impl with implementation Jackson.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@LSantha LSantha Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about deprecating this method or interface in favor of anew API? Then we may be able to remove it someday.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (0e127b2) 86.60% compared to head (bd56d90) 87.34%.
Report is 301 commits behind head on main.

Files Patch % Lines
...nts/internal/helper/image/AssetDeliveryHelper.java 82.70% 12 Missing and 11 partials ⚠️
...nents/internal/servlets/TableOfContentsFilter.java 88.19% 10 Missing and 7 partials ⚠️
...ents/internal/services/ContainerPostProcessor.java 62.79% 10 Missing and 6 partials ⚠️
...cq/wcm/core/components/internal/link/LinkUtil.java 86.95% 6 Missing and 6 partials ⚠️
...lets/embed/EmbeddableOptionsDataSourceServlet.java 47.05% 3 Missing and 6 partials ⚠️
...be/cq/wcm/core/components/util/ComponentUtils.java 73.52% 6 Missing and 3 partials ⚠️
...m/adobe/cq/wcm/core/components/internal/Utils.java 84.78% 1 Missing and 6 partials ⚠️
...s/internal/models/v3/NextGenDMImageURIBuilder.java 87.93% 1 Missing and 6 partials ⚠️
.../core/components/internal/models/v1/EmbedImpl.java 25.00% 5 Missing and 1 partial ⚠️
...ervlets/AllowedColorSwatchesDataSourceServlet.java 78.57% 0 Missing and 6 partials ⚠️
... and 24 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2593      +/-   ##
============================================
+ Coverage     86.60%   87.34%   +0.73%     
- Complexity     2313     2648     +335     
============================================
  Files           210      232      +22     
  Lines          6161     7080     +919     
  Branches        931     1073     +142     
============================================
+ Hits           5336     6184     +848     
- Misses          329      359      +30     
- Partials        496      537      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vladbailescu vladbailescu merged commit 918d784 into main Dec 18, 2023
14 checks passed
@vladbailescu vladbailescu deleted the issue/org.json-update branch December 18, 2023 07:09
@LSantha LSantha added this to the 2.24.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants