-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated org.json dependency #2593
Conversation
bundles/core/pom.xml
Outdated
@@ -529,6 +529,11 @@ | |||
<scope>test</scope> | |||
</dependency> | |||
|
|||
<dependency> | |||
<groupId>com.adobe.granite.bundles</groupId> | |||
<artifactId>json</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really deprecated, rather use JSON-P Impl with implementation Jackson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwin , unfortunately we cannot get rid completely of org.json
as it's part of a public API: https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/services/form/FormHandler.java#L39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about deprecating this method or interface in favor of anew API? Then we may be able to remove it someday.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
No description provided.