Skip to content

Commit

Permalink
Try going back to C++11 to see if errors change
Browse files Browse the repository at this point in the history
  • Loading branch information
skef committed Nov 5, 2024
1 parent 4a125df commit 7cd7519
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/testpythonpackage.yml
Original file line number Diff line number Diff line change
@@ -27,7 +27,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
# os: [ubuntu-latest, macos-latest, windows-latest]
os: [windows-latest]
python-version: ["3.9", "3.10", "3.11", "3.12"]
exclude:
- os: macos-latest
@@ -64,7 +65,7 @@ jobs:
if: matrix.os == 'windows-latest'
uses: microsoft/setup-msbuild@v1.3
with:
vs-version: '[17.0,17.10]'
vs-version: '[17.0,]'
msbuild-architecture: x64

- name: Set Windows generator to Visual Studio
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ if (NOT CMAKE_BUILD_TYPE)
endif()
message(STATUS "Build type is ${CMAKE_BUILD_TYPE}")

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 11)

# scikit-build
if(SKBUILD)

0 comments on commit 7cd7519

Please sign in to comment.