Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved witdth-9 logo to be more like the real logo #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved witdth-9 logo to be more like the real logo #4

wants to merge 1 commit into from

Conversation

airadier
Copy link

No description provided.

@moelders moelders added enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2018
@moelders
Copy link
Contributor

It could be an interesting improvement because adds some complexity to the algorithm.

Unfortunately, we can not include it now, however, it could be a nice feature so the challenge becomes difficult.

moelders
moelders requested changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@moelders moelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to update the test cases, or even better, to create new ones having two options of the challenge: simple and complex.

@moelders moelders removed the good first issue Good for newcomers label Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelders moelders moelders requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airadier @moelders