Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check download #513

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fix check download #513

merged 3 commits into from
Jan 5, 2024

Conversation

jonycoo
Copy link
Collaborator

@jonycoo jonycoo commented Jan 5, 2024

Download files of all Browsers to same directory. Ignore Download path.
Fix bug where empty input in step caused step to not be found.

@sMeilbeck sMeilbeck self-requested a review January 5, 2024 10:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sMeilbeck
sMeilbeck approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@sMeilbeck sMeilbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alles gut unter Annahme des ignorierten Directory Feldes

@sMeilbeck sMeilbeck merged commit b2ea65f into dev Jan 5, 2024
2 checks passed
@sMeilbeck sMeilbeck deleted the fixCheckDownload branch January 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sMeilbeck sMeilbeck sMeilbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonycoo @sMeilbeck