Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check picture step #469

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Check picture step #469

merged 6 commits into from
Oct 20, 2023

Conversation

jonycoo
Copy link
Collaborator

@jonycoo jonycoo commented Sep 26, 2023

No description provided.

@sMeilbeck sMeilbeck self-requested a review September 29, 2023 10:59
Copy link
Collaborator

@sMeilbeck sMeilbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeile 783 Error Message etwas uneindeutig, bitte noch abändern z.B. "Image Availabilty Check: Request Error to ..." ansonsten alles gut, auch Funktionalität soweit ich jetzt getestet habe - wobei ich mich z.B. frage, ob bei der Nameüberprüfung nach finden des Elementes nicht vielleicht ein SubString Match vileleicht ausreichen sollte, wäre etwas nutzerfreundlicher. DAs solltest du aber besser beurteilen können

@jonycoo jonycoo requested a review from sMeilbeck October 6, 2023 10:26
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sMeilbeck sMeilbeck merged commit 77e673d into dev Oct 20, 2023
3 checks passed
@sMeilbeck sMeilbeck deleted the checkPictureStep branch October 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants