Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReFT generate & orthogonal fixes #778

Merged
merged 7 commits into from
Jan 18, 2025
Merged

ReFT generate & orthogonal fixes #778

merged 7 commits into from
Jan 18, 2025

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 9, 2025

Resolves #772.

Provides the following fixes for the ReFT implementation:

  • support cases where seq_len < prefix/ suffix position (fixes issues with seq generation)
  • ensure orthogonal projection is always initialized with float32 (as half precision is not supported)

@calpt calpt mentioned this pull request Jan 9, 2025
Closed
4 tasks
@calpt calpt marked this pull request as ready for review January 11, 2025 15:18
lenglaender
lenglaender approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@lenglaender lenglaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and can be merged as soon as the one comment is resolved.

src/adapters/methods/reft.py Outdated Show resolved Hide resolved
@calpt calpt merged commit 66ff583 into adapter-hub:main Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenglaender lenglaender lenglaender approved these changes

@TimoImhof TimoImhof Awaiting requested review from TimoImhof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReFT does not support BFloat16
2 participants
@calpt @lenglaender