refactor(framework) Correct numpy client fit - return data type - error message #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamLindskog
requested review from
tanertopal and
danieljanes
as code owners
added 9 commits
December 10, 2024 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In client/numpy_client.py the EXCEPTION_MESSAGE_WRONG_RETURN_TYPE_FIT constant is set to wrong datatype.
Description
Function _fit(...), that checks returned value type wants a Tuple[List, int, Dict[str,Scalar]] but it should be Tuple[NDArray, int, Dict[str,Scalar]], also there are no tests that check this.
Related issues/PRs
Fixes #3948
Proposal
Add new tests to
numpy_client_test.pyand change_fit()function innumpy_client.pyto check forNDArrays.Explanation
We can use
isinstanceto check that parameters is a list and then validate that all elements in the list are NumPy arrays.Checklist
#contributions)Any other comments?
N/A