Add support for not closeable tabs #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SE7-KN8 Thanks so much for your contribution. After digging into it, I think I’d prefer to implement it in the reverse: keep the element in the template, but remove it if the option is passed. Would you mind making this change? |
|
No problem! I just changed it. |
adamschwartz
requested changes
Jan 29, 2022
| } | ||
|
|
||
| setTabCloseEventListener(tabEl) { | ||
| tabEl.querySelector('.chrome-tab-close').addEventListener('click', _ => this.removeTab(tabEl)) | ||
| const tab = tabEl.querySelector('.chrome-tab-close') | ||
| if(tab !== null){ |
There was a problem hiding this comment.
Please conform to the existing code style, e.g. if(tab !== null){ → if (tab !== null) {.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, it's possible to have tabs which are not closeable by the user. To make it easier to close them programmatically, the
addTabfunction now returns the created element, which can be later used to remove the tab.