Optimisation for RP2040 #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples graphicstest and pictureEmbed default to my Pico setup.
Limited testing but graphicstest runs OK and pixel operations now much faster.
|
yah so 1) we would definitely want to wait till the arduino core is out and 2) we'd prefer to stick any optimizations into SPITFT.cpp and minimize the complexity of this library becaues otherwise we'll have to do the same thing for HX8375, ST7789, GC901 etc... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes plus a companion pull request for Adafruit_GFX provide performance benefits for the RP2040 based boards when used in hardware SPI mode.
I suspect this pull needs to be refactored since SPI code has been introduced herein which breaks the partioning with Adafruit_GFX library. Also, although this works with Earle Philhower's Arduino core and calls low level SPI code, it may not be compatible with the "official" Arduino RP2040 core.