Fixes for re module bugs and other minor differences from CPython
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it doesn't work properly on 8.x.x without the fixes, let's leave them in for now. You could add comments or a draft PR to be merged at a later date to remove the fixes. |
michalpokusa
changed the title
re module bugs and other minor differences from Python
michalpokusa
force-pushed
the
workaround-for-re-module-bug
branch
from
b79c35e
to
a5750b2
Compare
michalpokusa
changed the title
re module bugs and other minor differences from CPython
michalpokusa
force-pushed
the
workaround-for-re-module-bug
branch
from
a5750b2
to
f565178
Compare
|
I think it is now ready for merge, after release of 9.0.0 I will publish a PR that removes the workaround, as the EDIT1: As the CP 9.0.0 is nearly stable, the workarounds will not be necessary, other changes that were present in this PR are included in #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪛Fixes:
FileNotFoundError, which is not present in CircuitPythonstr.title()which is not present in CircuitPythonremodule that incorrectly detected positions of unicode charactersremodule, that incorrectly matches[\s\S]pattern, so it had to be changed to something that does the same thing, using other tokensLast two ones should be a temporary solution, until the bugs are fixed, but for now they are necessary.
🏗️ Refactor:
.htmlfiles to HTML commentsAdditional testing would be highly appreciated. 😃