Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no <style> tags test #325

Closed
wants to merge 1 commit into from
Closed

Add no <style> tags test #325

wants to merge 1 commit into from

Conversation

larouxn
Copy link
Collaborator

@larouxn larouxn commented Sep 6, 2020

Add a test to ensure we don't add SVGs with <style> tags. Note, should allow inline styles.
Screen Shot 2020-09-06 at 12 59 14

Note, fails for some current SVGs as they have <style> tags. Maybe we should create a "legacy exceptions list". 🤔

Enforces the following line in the CONTRIBUTING.md.

All styles should be inline. There should be no <style> tag unless it is absolutely necessary.

Resolves #179
Part of resolving #184

@larouxn larouxn self-assigned this Sep 6, 2020
@larouxn
Copy link
Collaborator Author

larouxn commented Oct 22, 2020

Closing this, at least for now, as I don't currently have time.

@larouxn larouxn closed this Oct 22, 2020
@larouxn larouxn deleted the add_no_style_tags_test branch October 22, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent <style> tags in SVG
1 participant