Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ventipay icon #1239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cmelendez
Copy link

Why are you adding this icons?

I'm adding this icon for our payments app: https://apps.shopify.com/venti

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

Screenshot 2024-10-14 at 23 29 23

If the icons are intended for use by Shopify, please provide the following info:

What's the expected date of this change to deploy on Shopify?
As soon as possible, please.

@cmelendez
Copy link
Author

Hi there @dannye0231. Is there an approximate ETA on this? It's our first PR on this repo. Thanks!

@dannye0231
Copy link
Contributor

Hi @cmelendez , we're aiming to have another merge at the end of next week. I'll let you know if anything changes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants