Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a tool to define SVG #184

Open
tauthomas01 opened this issue May 8, 2019 · 2 comments
Open

Build a tool to define SVG #184

tauthomas01 opened this issue May 8, 2019 · 2 comments

Comments

@tauthomas01
Copy link
Collaborator

Issue

New icon requests require manual review and such process takes time. What if we could create a tool that could simplify the workflow and reduce manual work.

The following issues are some examples of what the tool can take care of:
#183
#182
#179

Proposed solution

There could be a tool that reads the generated SVG, reviews the structure and modifies the file according to some requirements we establish so the contributors won't have to manually modify inside the file.

@tauthomas01
Copy link
Collaborator Author

cc. @NathanPJF

@NathanPJF
Copy link
Collaborator

Thanks for making a note of this. It would be cool if

  • Contributions are only for the icon in a new directory like app/assets/svg/payment_icons
  • We put the border path and background-color ourselves in a build tool, and generate a new icon for app/assets/images/payment_icons
  • Contributors could specify the background (if they don't want white) in a separate place like payment_icons.yml

So American express entry becomes

  name: american_express
  label: American Express
  color: #032761
  group: credit_cards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants