Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple id attributes in SVG #182

Open
tauthomas01 opened this issue May 8, 2019 · 0 comments
Open

Prevent multiple id attributes in SVG #182

tauthomas01 opened this issue May 8, 2019 · 0 comments

Comments

@tauthomas01
Copy link
Collaborator

Issue

Some of the newest icon requests contain multiple id attributes that are unused.

Example of a multiple unused id instances:
image

Reference example

This is mostly due to SVG icons generated by vector applications such as Illustrator that keep its original layers. Having unused id is not necessary to keep in our end.

Proposed solution

We should have a test that rejects all id attributes except the <title> one because it's used to reference the aria-labelledby attribute for accessibility reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant