Priority: fix for bin lookup #5366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Could you please add some tests to cover this new case e.g.
test/remote/gateways/remote_priority_test.rb:327
def test_failed_verify
response = @gateway.verify(@invalid_credit_card)
assert_failure response
assert_match 'No bank information found for bin number', response.message
end
Maybe an adaptation to the previous example for unit tests
Description ------------------------- Send 8 digits for bin lookups instead of 7. Unit tests ------------------------- 6159 tests, 80990 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote tests ------------------------- 31 tests, 84 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 83.871% passed Failures not related to changes Rubocop ------------------------- 808 files inspected, no offenses detected
Buitragox
force-pushed
the
OPPS-238_priority_verify_quick_fix
branch
from
08d91dd to
4b0e082
Compare
|
@sinourain Hey I added some unit tests. It was a bit trickier than expected, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send 8 digits for bin lookups instead of 7.
Unit tests
6157 tests, 80984 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote tests
31 tests, 84 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 83.871% passed
Failures not related to changes
Rubocop
808 files inspected, no offenses detected