Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersaPay: refactor authorization from structure #5363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Dec 10, 2024

Summary

This refactor the returned structure
in the authorization.

SER-1516

Unit Tests

Finished in 0.034439 seconds.
33 tests, 170 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests

Finished in 46.01067 seconds.
25 tests, 42 assertions, 19 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
24% passed

Rubocop

806 files inspected, no offenses detected

Summary
----------------
This refactor the returned structure
in the authorization.

[SER-1516](https://spreedly.atlassian.net/browse/SER-1516)

Unit Tests
----------------
Finished in 0.034439 seconds.
33 tests, 170 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests
----------------
Finished in 46.01067 seconds.
25 tests, 42 assertions, 19 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
24% passed

Rubocop
----------------
806 files inspected, no offenses detected
@gasb150 gasb150 marked this pull request as draft December 10, 2024 15:25
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much 👌 LTGM

@gasb150 gasb150 marked this pull request as ready for review December 10, 2024 15:50
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants