Stripe PI: Update API version #5360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
update_stripe_pi_version
branch
3 times, most recently
from
630c7af to
e11d0f3
Compare
Update API version to 2022-11-15 Remote 104 tests, 483 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Buitragox
reviewed
Dec 18, 2024
| @@ -65,7 +64,7 @@ def create_intent(money, payment_method, options = {}) | |||
| end | |||
|
|
|||
| def show_intent(intent_id, options) | |||
| commit(:get, "payment_intents/#{intent_id}", nil, options) | |||
| commit(:get, "payment_intents/#{intent_id}?expand[]=latest_charge.balance_transaction", nil, options) | |||
There was a problem hiding this comment.
I noticed that you added the expand parameter to the URL. Should this always be added? I understand that we need this in Spreedly, but should this be added in ActiveMerchant?
| @@ -228,11 +221,11 @@ def void(intent_id, options = {}) | |||
|
|
|||
| def refund(money, intent_id, options = {}) | |||
| if intent_id.include?('pi_') | |||
| intent = api_request(:get, "payment_intents/#{intent_id}", nil, options) | |||
| intent = api_request(:get, "payment_intents/#{intent_id}?expand[]=latest_charge.balance_transaction", nil, options) | |||
Comment on lines
+330
to
+333
| if url.include?('payment_intents') | ||
| post[:expand].concat(['latest_charge', 'latest_charge.balance_transaction']) | ||
| elsif url.include?('setup_intents') | ||
| post[:expand] << 'latest_attempt' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update API version to 2022-11-15
Remote
104 tests, 483 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed