Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersaPay: Improve Message Error and Error Mapping #5357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Dec 4, 2024

Summary

This add suppor for NetworkTokenizedCreditCard with redsys
Enhance Scrubbing method

SER-1515
SER-1540

Unit Tests

Finished in 0.039932 seconds.
30 tests, 164 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests

Finished in 27.288085 seconds.
28 tests, 51 assertions, 19 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
32.1429% passed

Rubocop

803 files inspected, no offenses detected

@gasb150 gasb150 marked this pull request as draft December 4, 2024 18:53
Copy link
Collaborator

@javierpedrozaing javierpedrozaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/unit/gateways/versa_pay_test.rb Show resolved Hide resolved
Summary
----------------
This add suppor for NetworkTokenizedCreditCard with redsys
Enhance Scrubbing method

[SER-1515](https://spreedly.atlassian.net/browse/SER-1515)
[SER-1540](https://spreedly.atlassian.net/browse/SER-1540)

Unit Tests
----------------
Finished in 0.039932 seconds.
30 tests, 164 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests
----------------
Finished in 27.288085 seconds.
28 tests, 51 assertions, 19 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
32.1429% passed

Rubocop
----------------
803 files inspected, no offenses detected
@gasb150 gasb150 force-pushed the SER-1515_No_Message_error branch from 7847756 to aef0ff5 Compare December 5, 2024 15:37
@gasb150 gasb150 marked this pull request as ready for review December 5, 2024 15:39
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants