use util.Fingerprint to fix panic ce #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugsGuru
force-pushed
the
fix-fingerprint-panic-ce
branch
from
006be20
to
e6bc8a0
Compare
ColdWaterLW
requested review from
winfredLIN
and removed request for
ColdWaterLW
winfredLIN
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的 issue
#2603
描述你的变更
github.com/percona/go-mysql/query中生成指纹的函数Fingerprint特殊情况会panic，使用github.com/actiontech/sqle/sqle/driver/mysql/util中的指纹函数替换
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_docassign in @winfredLIN