Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Deps again #2372

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Upgrading Deps again #2372

merged 5 commits into from
Nov 18, 2024

Conversation

gnunicorn
Copy link
Contributor

Upgrading to latest matrix-rust-sdk, flutter dependencies.

Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 14.13043% with 79 lines in your changes missing coverage. Please review.

Project coverage is 27.32%. Comparing base (2b8ac72) to head (aa2006b).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
native/file-event-cache/src/lib.rs 5.55% 34 Missing ⚠️
native/acter/src/api/room.rs 0.00% 16 Missing ⚠️
native/file-event-cache/src/queued.rs 0.00% 11 Missing ⚠️
native/acter/src/api/attachments.rs 0.00% 8 Missing ⚠️
native/acter/src/api/client.rs 0.00% 3 Missing ⚠️
native/acter/src/api/account.rs 0.00% 1 Missing ⚠️
native/acter/src/api/common.rs 0.00% 1 Missing ⚠️
native/acter/src/api/convo.rs 0.00% 1 Missing ⚠️
native/acter/src/api/profile.rs 0.00% 1 Missing ⚠️
native/acter/src/api/search.rs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
- Coverage   27.35%   27.32%   -0.04%     
==========================================
  Files         602      602              
  Lines       41700    41740      +40     
==========================================
- Hits        11408    11404       -4     
- Misses      30292    30336      +44     
Flag Coverage Δ
integration-test 36.80% <10.22%> (-0.11%) ⬇️
unittest 19.23% <8.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copy link
Contributor

features = ["experimental-sliding-sync"]
features = [
"experimental-sliding-sync",
"rustls-tls",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are adding matrix-sdk in the acter-core now and that means this flag is needed for clippy to succeed in all cases :( .

@gnunicorn gnunicorn mentioned this pull request Nov 17, 2024
@gnunicorn gnunicorn merged commit f496a03 into main Nov 18, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-demo Include demo builds in this PR dependencies Pull requests that update a dependency file
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

1 participant