-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Fixes #2361
General Fixes #2361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
- Coverage 27.15% 27.14% -0.01%
==========================================
Files 601 602 +1
Lines 41763 41780 +17
==========================================
+ Hits 11340 11342 +2
- Misses 30423 30438 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine, just two minor remarks.
taskList: taskList, | ||
taskName: taskName, | ||
builder: (context) => Padding( | ||
padding: MediaQuery.of(context).viewInsets, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curios ... why is that not needed in other cases? Is it because the object then pulls the auto-focus? But others should be doing that, too, no? I'd like to understand the cause here ...
Or should we wrap that in a safe-area?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know exact root cause. I also faced similar kind of issue where I developer createEditTitle common widget where it was working fine on some area and misbehave at some places.
Above code just fixed the issue earlier also so applied it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also confirm that wrapping with safe-area
doesn't fixed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... that is unsatisfying ... would be good to figure out the root cause at some point...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm true, let me check if I can figure out something
Commit: f7a4d0a
Pin.Icon.mov
Commit: 5ea4214
Add.Task.mov
Commit: 77f051d
News.Post.Colors.mov
Commit: 0cfca17
Space.Overview.-.Name.and.Order.Chnage.mov
Commit: becf82f
Boost.Scroll.-.Desktop.mov
6)Fixes, Event list order is not based on bookmark priority
Commit : ac27243
Bookmark.event.Priority.mov