Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge counter #2349

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix badge counter #2349

merged 2 commits into from
Nov 5, 2024

Conversation

gnunicorn
Copy link
Contributor

We have had reports that the app Badge counter wasn't properly updating (especially on iOS and Mac). Looks like we are updating it but based on the still "active" notifications count, which might not be what the user expects. And as they can't really clear that listing (as it is with the system) for now, the number annoys quite some people. To resolve that, I've added a temporary fix removing the badge counter entirely (setting it to 0 regardless of current known number of notifications) until we have the activity center in a way that can allow for them to be cleared.

@gnunicorn gnunicorn added minor This is a changeset with little need for review. f-push-notifications Problem with the push notifications feature labels Nov 5, 2024
@gnunicorn gnunicorn changed the title Ben fix badge counter Fix badge counter Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.08%. Comparing base (4d77a69) to head (a2c04b2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
+ Coverage   27.05%   27.08%   +0.02%     
==========================================
  Files         596      596              
  Lines       41433    41433              
==========================================
+ Hits        11211    11222      +11     
+ Misses      30222    30211      -11     
Flag Coverage Δ
integration-test 37.08% <ø> (+0.06%) ⬆️
unittest 18.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnunicorn gnunicorn merged commit ded72ce into main Nov 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f-push-notifications Problem with the push notifications feature minor This is a changeset with little need for review.
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

1 participant