Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address fixes for #2343 #2347

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Address fixes for #2343 #2347

merged 5 commits into from
Nov 10, 2024

Conversation

gnunicorn
Copy link
Contributor

Mainly minor fixes I missed in the review and refactoring the code to be in the actions folder
Also: forward to the newly created task after creation now!

@gnunicorn gnunicorn added s-tasks Tasks-Sektion minor This is a changeset with little need for review. labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.26%. Comparing base (db86f03) to head (faae433).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
+ Coverage   27.11%   27.26%   +0.15%     
==========================================
  Files         597      601       +4     
  Lines       41441    41575     +134     
==========================================
+ Hits        11236    11336     +100     
- Misses      30205    30239      +34     
Flag Coverage Δ
integration-test 37.05% <ø> (-0.07%) ⬇️
unittest 19.05% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnunicorn gnunicorn merged commit d4329fe into main Nov 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor This is a changeset with little need for review. s-tasks Tasks-Sektion
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

1 participant