Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restarting sync #2318

Merged
merged 17 commits into from
Nov 18, 2024
Merged

Fix restarting sync #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6793e2f
Remove left-over read-receipt-sync-attempt
gnunicorn Oct 25, 2024
ada9e5a
Test proofing the sync problem
gnunicorn Oct 25, 2024
325b4fb
Ensure we don't sync already synced room histories again
gnunicorn Oct 25, 2024
58d5459
Changelog
gnunicorn Oct 25, 2024
5af6d72
Remove necessity for mock data for rust integration tests
gnunicorn Oct 25, 2024
67f402c
Remove mock cli command
gnunicorn Oct 25, 2024
867884b
fixing tests
gnunicorn Oct 27, 2024
8daba78
Fix sync up code when already synced up: fix endless stalling tests
gnunicorn Oct 28, 2024
ea63937
Improved history sync tracking
gnunicorn Oct 28, 2024
de0fa32
Merge remote-tracking branch 'origin/main' into ben-fix-restarting-sync
gnunicorn Nov 10, 2024
4a8f330
Upgrading flutter deps
gnunicorn Nov 14, 2024
8287f50
Upgrade matrix-rust-sdk dependency
gnunicorn Nov 14, 2024
2b90e2e
Fix store config usage pattern
gnunicorn Nov 17, 2024
5d3b71d
Fix acter_notify pub spec
gnunicorn Nov 17, 2024
aa2006b
fix dependency feature
gnunicorn Nov 17, 2024
f496a03
Merge branch 'ben-upgrading-deps-2446' into ben-fix-restarting-sync
gnunicorn Nov 17, 2024
1d46b21
Properly indicate the loading starting signal
gnunicorn Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/2318-sync-fixes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix to not refresh the entire space history on every app start anymore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now, it'd only sync if there's a need for sync ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's the idea. so far, we synced the entire history on every start...

37 changes: 21 additions & 16 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,16 @@ default-members = ["native/acter"]
git = "https://github.com/matrix-org/matrix-rust-sdk"
# path = "../matrix-rust-sdk/crates/matrix-sdk"
default-features = false
features = ["experimental-sliding-sync"]
features = [
"experimental-sliding-sync",
"rustls-tls",
]


[workspace.dependencies.matrix-sdk-base]
git = "https://github.com/matrix-org/matrix-rust-sdk"
# path = "../matrix-rust-sdk/crates/matrix-sdk-base"
default-features = false

[workspace.dependencies.matrix-sdk-sqlite]
git = "https://github.com/matrix-org/matrix-rust-sdk"
# path = "../matrix-rust-sdk/crates/matrix-sdk-sqlite"
Expand Down
Loading
Loading