Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : Space Details - Add Task Inline option not working #2094

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Aug 23, 2024

Fixes, https://github.com/acterglobal/a3-meta/issues/408

After bit of debugging and research, finally able to fixes this issue. Was pretty tough to find this issue.

Issue Video:

RPReplay_Final1721983050.MP4

Video after fixes:

Add.Task.mov

Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

@gnunicorn
Copy link
Contributor

@kumarpalsinh25 kudos for finding it ... looking at how we changed things, I was wondering if we wanted to replace this (by now pretty uniquely different) widget with the typical bottom-up drawer instead .... as we have several other issues on it, like the way that submitting an item isn't clear ...

isn't blocking this from merge though.

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kumarpalsinh25
Copy link
Contributor Author

@kumarpalsinh25 kudos for finding it ... looking at how we changed things, I was wondering if we wanted to replace this (by now pretty uniquely different) widget with the typical bottom-up drawer instead .... as we have several other issues on it, like the way that submitting an item isn't clear ...

isn't blocking this from merge though.

Yes planning to the same. On scrolling, this inline doesn't seems to be good UI-UX. Will do bottom-up view on later PR along with other improvements on Task Module. Merging this PR as of now to get out from current blocker.

@kumarpalsinh25 kumarpalsinh25 merged commit 9043958 into main Aug 23, 2024
21 checks passed
@kumarpalsinh25 kumarpalsinh25 deleted the kumar/bug-add-task branch August 23, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants