Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin List Item UI-UX Improvements #2082

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Aug 20, 2024

Pin.List.mov

Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

@kumarpalsinh25 kumarpalsinh25 marked this pull request as ready for review August 20, 2024 11:08
@gnunicorn
Copy link
Contributor

gnunicorn commented Aug 20, 2024

@kumarpalsinh25 isn't that a bit to small and tricky if you used your fingers/non-pointer-devices? Instead I see that the user could easily accidentally tap that with their finger though they intend to tap the entire field/text entry and be routed where they don't want to go ... could be a bit confusing ...

we are not doing that in the top bars in other places either ... (where it be <- anyways) but uniquely here ... not sure I'd expect clicking this to route me anywhere...

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise this is fine ... UX wise I am not sure...

@kumarpalsinh25
Copy link
Contributor Author

@gnunicorn

UX wise I am not sure...

I was also bit confusion at the development time regarding putting space name clickable. Let me remove it and make on space label view only.

@kumarpalsinh25 kumarpalsinh25 merged commit f23e343 into main Aug 20, 2024
21 checks passed
@kumarpalsinh25 kumarpalsinh25 deleted the kumar/pin-list-improvements branch August 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants