Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load and save composer draft for chat room input text #2077

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

gtalha07
Copy link
Contributor

@gtalha07 gtalha07 commented Aug 19, 2024

Fixes meta#448. Implements ComposerDraft for saving composed message state of room in an improved way .i.e. can be restored in between restarts and saves reply, edit states of message. See it in action:

Desktop: (Shows different states .i.e. text, edit/reply state storing between two rooms)

Screen.Recording.2024-08-20.at.6.42.42.PM.mov

Mobile: (Shows different states storing between restarts)

Screen.Recording.2024-08-20.at.6.56.11.PM.mov

@gtalha07 gtalha07 marked this pull request as ready for review August 20, 2024 18:00
@gnunicorn gnunicorn added the merge post release only Merge this only after the new release has been cut label Aug 21, 2024
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test seem to be mostly checking itself, not the actual functionality and I think the wiring can be improved upon as well. comments inlined.

app/lib/features/chat/widgets/custom_input.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/custom_input.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/custom_input.dart Outdated Show resolved Hide resolved
app/lib/features/chat/widgets/custom_input.dart Outdated Show resolved Hide resolved
app/test/features/chat/custom_input_test.dart Outdated Show resolved Hide resolved
app/test/features/chat/custom_input_test.dart Outdated Show resolved Hide resolved
app/test/features/chat/custom_input_test.dart Outdated Show resolved Hide resolved
app/test/features/chat/custom_input_test.dart Outdated Show resolved Hide resolved
app/test/helpers/mocks.dart Show resolved Hide resolved
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gtalha07 gtalha07 merged commit e4fa6b8 into acterglobal:main Aug 26, 2024
20 of 21 checks passed
@gtalha07 gtalha07 deleted the talha/compose-draft-chat branch September 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter merge post release only Merge this only after the new release has been cut
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants