-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load and save composer draft for chat room input text #2077
Merged
gtalha07
merged 11 commits into
acterglobal:main
from
gtalha07:talha/compose-draft-chat
Aug 26, 2024
Merged
load and save composer draft for chat room input text #2077
gtalha07
merged 11 commits into
acterglobal:main
from
gtalha07:talha/compose-draft-chat
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
the
merge post release only
Merge this only after the new release has been cut
label
Aug 21, 2024
gnunicorn
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test seem to be mostly checking itself, not the actual functionality and I think the wiring can be improved upon as well. comments inlined.
gtalha07
force-pushed
the
talha/compose-draft-chat
branch
from
August 21, 2024 20:41
1b39e1e
to
cd78762
Compare
gnunicorn
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes meta#448. Implements
ComposerDraft
for saving composed message state of room in an improved way .i.e. can be restored in between restarts and saves reply, edit states of message. See it in action:Desktop: (Shows different states .i.e. text, edit/reply state storing between two rooms)
Screen.Recording.2024-08-20.at.6.42.42.PM.mov
Mobile: (Shows different states storing between restarts)
Screen.Recording.2024-08-20.at.6.56.11.PM.mov