Device Calendar Sync #2072
Merged
Device Calendar Sync #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
s-integration
kumarpalsinh25
approved these changes
Aug 20, 2024
| ); | ||
| } | ||
|
|
||
| Future<void> _refreshCalendar( |
There was a problem hiding this comment.
Skipping review of _refreshCalendar as not getting much idea of the code.
There was a problem hiding this comment.
a shame, as this is the main part of the code ;)
| if (calendars == null) { | ||
| return []; | ||
| } | ||
| if (Platform.isAndroid) { |
There was a problem hiding this comment.
Any reason for this platform specific condition?
There was a problem hiding this comment.
yes, due to platform specific behaviors (iOS doesn't have any accountName property) this will only be correct on Android.
There was a problem hiding this comment.
had to update this slightly for iOS support. But nothing major. Also limiting our deleting to local calendars so we don't accidentally delete others ... like one they might have named "Acter" in their google calendar.
|
I take it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings syncing of all events not-denied to your device calendar on Android & iOS. See it in Action (the other app is the emulator Default Calendar App from Google):
device-calendar-integration-zero.mp4
It is behind a feature flag, that you can hard toggle to see and remove the calendar:
labs-flag.mp4
And on iOS (emulator) as well:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-20.at.10.55.26.mp4
The following caveats apply:
yes?)To the reviewer
Next to the actual feature the following refactors were necessary:
home_shellinto anapp_shellthat is moved toconfigas it is about setting up the general infrastructure. Aside from moving the file and outsourcing the LogoutWidget (which is otherwise features wise untouched), this moves the_initprocess to give us more executive control, like in this case make sure we are not asking for multiple permissions at the same time but after one another (notifications & calendar permission).