Limit concurrent HTTP requests #1898

gnunicorn · 2024-06-28T17:02:49Z

Upgrades to latest matrix-rust-sdk
link to the upgraded matrix-rust-sdk fork that has support for limiting current http requests
set the limits to 100 on desktop, 50 on android and 20 on iOS

Attempt to fix that #1788 errors.

github-actions · 2024-06-28T17:13:23Z

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

📰 Add a markdown file in .changes/ explaining what changed

bitfriend · 2024-07-02T16:08:35Z

App crashes when clicking of chat list under reqwest limitation.
This is last part of log.
Full log is too large to paste here.

[2024-07-02][22:49:28.105797][acter::api::receipt][INFO] receipt: ReceiptEventContent({"$xHDPrULegcKltaziYo4HrjSHXorte888VfqEFkBOYQc": {"m.read": {"@s7evink:matrix.org": Receipt { ts: Some(2024-07-02T14:49:24.890), thread: Main }}}})
[2024-07-02][22:49:28.106074][acter::api::receipt][INFO] receipt iter: "$xHDPrULegcKltaziYo4HrjSHXorte888VfqEFkBOYQc"
[2024-07-02][22:49:28.106226][acter::api::receipt][INFO] user read receipt: Receipt { ts: Some(2024-07-02T14:49:24.890), thread: Main }
[2024-07-02][22:49:28.113763][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:29.214493][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:29.215840][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:30.118503][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:30.119436][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:32.330404][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:32.331365][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:33.118214][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:33.118797][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:37.455075][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:37.455488][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:41.649542][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:41.649968][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:42.710596][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:42.711038][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:46.143401][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:46.143779][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:49.517595][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:49.518006][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:52.710906][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:52.711755][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:55.352692][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:55.352871][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:57.511837][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:57.512968][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:49:58.477226][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:49:58.477942][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:00.363013][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:00.363408][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:01.327462][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:01.327996][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:03.479865][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:03.480340][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:04.878801][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:04.879177][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:05.963603][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:05.963386][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:07.912521][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:07.912986][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:12.737804][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:12.738161][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:19.854411][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:19.854807][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:22.203709][matrix_sdk_crypto::backups][WARN] Trying to backup room keys but no backup key was found
[2024-07-02][22:50:22.204060][acter::api::client::sync][INFO] received sync callback
[2024-07-02][22:50:22.982421][a3::common::room][ERROR] room not found Room not found null

gnunicorn · 2024-07-05T14:00:07Z

@bitfriend pretty sure this doesn't come from this PR ... can you try again since I merged main (that contained the fix)...

bitfriend · 2024-07-08T05:19:13Z

@bitfriend pretty sure this doesn't come from this PR ... can you try again since I merged main (that contained the fix)...

But main is working fine now.
It doesn't show any error when navigating to chat list page.

…rrors

gnunicorn · 2024-07-09T11:46:40Z

@bitfriend I pushed an update with a fix. does this still happen to you with it?

…bal/a3 into ben-limit-http-requests

bitfriend

Limit of concurrent requests was great idea.
Nice work.

bitfriend · 2024-07-09T16:23:19Z

On navigation to chat list page, app crash seems to disappear.
Great job.

gnunicorn added 4 commits June 28, 2024 19:03

Upgrade to latest matrix-rust-sdk

ba365a6

Update to new retry-sending facilities

1c61af8

Simplify media store limiting by using the semaphore directly

88ea4fd

Limit the concurrent HTTP request to 20 on mobile, 100 on desktop

8772f95

gnunicorn requested a review from bitfriend June 28, 2024 17:02

Update to latest API

144edda

gnunicorn added build-demo Include demo builds in this PR and removed build-demo Include demo builds in this PR labels Jul 4, 2024

gnunicorn added 2 commits July 4, 2024 21:04

Merge remote-tracking branch 'origin/main' into ben-limit-http-requests

5068ea6

Switch back to mainline rust-sdk

ffe3c20

gnunicorn added 2 commits July 5, 2024 19:30

Merge remote-tracking branch 'origin/main' into ben-limit-http-requests

83fe326

Fixing several lints

4855ac0

gnunicorn added 3 commits July 9, 2024 16:45

Merge remote-tracking branch 'origin/main' into ben-limit-http-requests

24bc2ed

Update to latest matrix rust sdk

358e4ba

Simplify room providers, fix several possible cases of RoomNotFound e…

5c40df1

…rrors

gnunicorn and others added 6 commits July 9, 2024 20:00

Remove RoomProfile, simplify user profile for caching via providers

6a55f7b

use room_filtered for cleaner room list generation

c150971

remove unnused import

5d9ac3c

forgot to commit one

9b8199e

Fix the missing in api change

97ec76a

Merge branch 'ben-limit-http-requests' of https://github.com/acterglo…

397b2da

…bal/a3 into ben-limit-http-requests

bitfriend approved these changes Jul 9, 2024

View reviewed changes

gnunicorn merged commit a4dc750 into main Jul 10, 2024
27 checks passed

gnunicorn deleted the ben-limit-http-requests branch July 10, 2024 10:38

gnunicorn mentioned this pull request Jul 16, 2024

Os Error: too many files open + Error sending Request #1788

Closed

bitfriend mentioned this pull request Jul 29, 2024

Error loading room/space, too many files open #1682

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit concurrent HTTP requests #1898

Limit concurrent HTTP requests #1898

gnunicorn commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

bitfriend commented Jul 2, 2024 •

edited

Loading

gnunicorn commented Jul 5, 2024

bitfriend commented Jul 8, 2024

gnunicorn commented Jul 9, 2024

bitfriend left a comment •

edited

Loading

bitfriend commented Jul 9, 2024

Limit concurrent HTTP requests #1898

Limit concurrent HTTP requests #1898

Conversation

gnunicorn commented Jun 28, 2024

github-actions bot commented Jun 28, 2024

bitfriend commented Jul 2, 2024 • edited Loading

gnunicorn commented Jul 5, 2024

bitfriend commented Jul 8, 2024

gnunicorn commented Jul 9, 2024

bitfriend left a comment • edited Loading

Choose a reason for hiding this comment

bitfriend commented Jul 9, 2024

bitfriend commented Jul 2, 2024 •

edited

Loading

bitfriend left a comment •

edited

Loading