Merge remote-tracking branch 'origin/main' into kumar/refactor-pin-de…

…tails

.changes/2060-spanish-and-arabic.md

@@ -0,0 +1 @@
+- Acter is now available in Spanish (thanks to Sandra) and in Arabic (thanks, Omar!)

.github/workflows/build-docs.yml

@@ -49,7 +49,7 @@ jobs:
         run: ls -ltas packages/rust_sdk/lib/
 
       - name: Build Dart SDK
-        run: flutter pub global run dartdoc --output ../../../docs/api/main/dart-sdk/
+        run: flutter pub global run dartdoc --output ../../docs/api/main/dart-sdk/
         working-directory: packages/rust_sdk
 
       - name: Upload artifact

.github/workflows/deploy-nightly.yml

@@ -8,6 +8,9 @@ on:
   schedule:
    - cron: 0 1 * * 0-3,5-6
 
+permissions:
+  contents: write
+
 jobs:
   run_checker:
     runs-on: ubuntu-latest
@@ -277,7 +280,7 @@ jobs:
  ######   ####    ##    ##     ##  #######  ########     ##         #######  ########  ######## ####  ######  ##     ## 
 
   publish:
-    environment: nightly
+    environment: release
     runs-on: ubuntu-latest
     name: Publish
     if: ${{ github.event.schedule }}
@@ -288,7 +291,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          token: ${{ secrets.PAT }}
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       - uses: actions/download-artifact@v3
         with:

.github/workflows/deploy-release.yml

@@ -4,6 +4,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.target || 'all' }}
   cancel-in-progress: true
 
+permissions:
+  contents: write
+
 on:
   workflow_dispatch:
     inputs:
@@ -66,9 +69,8 @@ jobs:
       tag: v${{ inputs.new_version || steps.version.outputs.version }}
       version: ${{ inputs.new_version || steps.version.outputs.version }}
       build_num: ${{ steps.build_num.outputs.build_num }}
-      prev_tag: ${{ inputs.prev_tag || 'release-latest' }}
       targets: ${{ inputs.target || 'all' }}
-      release_title: ${{ inputs.custom_title || 'Release'}}
+      release_title_prefix: ${{ inputs.custom_title || 'Release'}}
     steps:
       - id: version
         # the suffix 0 allows us to provide up to 9 more hotfixes on the same day
@@ -83,7 +85,7 @@ jobs:
     with:
       build_num: ${{ needs.tags.outputs.build_num }}
       version: ${{ needs.tags.outputs.version }}
-      release_title: ${{ needs.tags.outputs.release_title }} ${{ needs.tags.outputs.tag }}
+      release_title: "${{ needs.tags.outputs.release_title_prefix }} ${{ needs.tags.outputs.tag }}"
       release_tag: ${{ needs.tags.outputs.tag }}
       targets: ${{ needs.tags.outputs.targets }}
       release: true
@@ -354,7 +356,7 @@ jobs:
  ######   ####    ##    ##     ##  #######  ########     ##         #######  ########  ######## ####  ######  ##     ## 
 
   publish:
-    environment: nightly
+    environment: release
     runs-on: ubuntu-latest
     name: Publish
     # if: ${{ github.event.schedule }}
@@ -365,7 +367,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          token: ${{ secrets.PAT }}
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       - uses: actions/download-artifact@v3
         with:
@@ -413,7 +415,7 @@ jobs:
           # publish this full release now
           draft: true
           generate_release_notes: false
-          name: ${{ needs.tags.outputs.release_title }} ${{ needs.tags.outputs.tag }}
+          name: "${{ needs.tags.outputs.release_title_prefix }} ${{ needs.tags.outputs.tag }}"
           tag_name: ${{ needs.tags.outputs.tag }}
           body_path: CHANGELOG.md
           prerelease: false

app/lib/common/actions/close_room.dart

@@ -4,7 +4,6 @@ import 'package:acter/common/providers/sdk_provider.dart';
 import 'package:acter/common/providers/space_providers.dart';
 import 'package:acter/common/toolkit/buttons/danger_action_button.dart';
 import 'package:acter/common/utils/routes.dart';
-
 import 'package:acter/common/widgets/room/room_profile_header.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_easyloading/flutter_easyloading.dart';

app/lib/common/actions/report_content.dart

@@ -1,7 +1,6 @@
 import 'package:acter/common/providers/chat_providers.dart';
 import 'package:acter/common/providers/room_providers.dart';
 import 'package:acter/common/providers/space_providers.dart';
-
 import 'package:acter/common/toolkit/buttons/primary_action_button.dart';
 import 'package:acter/common/widgets/default_dialog.dart';
 import 'package:acter/common/widgets/input_text_field.dart';

app/lib/common/providers/common_providers.dart

@@ -10,7 +10,7 @@ import 'package:flutter/material.dart';
 import 'package:logging/logging.dart';
 import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::providers');
+final _log = Logger('a3::common::common_providers');
 
 // Loading Providers
 final loadingProvider = StateProvider<bool>((ref) => false);

app/lib/common/providers/notifiers/chat_notifiers.dart

@@ -8,7 +8,7 @@ import 'package:flutter/widgets.dart';
 import 'package:logging/logging.dart';
 import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::chat');
+final _log = Logger('a3::common::chat_notifiers');
 
 class AsyncConvoNotifier extends FamilyAsyncNotifier<Convo?, String> {
   late Stream<bool> _listener;

app/lib/common/providers/notifiers/notification_settings_notifier.dart

@@ -5,7 +5,7 @@ import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
 import 'package:logging/logging.dart';
 import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::notification_settings');
+final _log = Logger('a3::common::notification_settings_notifier');
 
 class AsyncNotificationSettingsNotifier
     extends AsyncNotifier<NotificationSettings> {

app/lib/common/providers/notifiers/reactions_notifiers.dart

@@ -4,7 +4,7 @@ import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
 import 'package:logging/logging.dart';
 import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::reactions');
+final _log = Logger('a3::common::reactions_notifiers');
 
 class ReactionManagerNotifier
     extends FamilyNotifier<ReactionManager, ReactionManager> {

app/lib/common/providers/notifiers/room_notifiers.dart

@@ -5,10 +5,10 @@ import 'package:acter/features/home/providers/client_providers.dart';
 import 'package:acter_avatar/acter_avatar.dart';
 import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
 import 'package:flutter/material.dart';
-import 'package:riverpod/riverpod.dart';
 import 'package:logging/logging.dart';
+import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::room');
+final _log = Logger('a3::common::room_notifiers');
 
 class AsyncMaybeRoomNotifier extends FamilyAsyncNotifier<Room?, String> {
   late Stream<bool> _listener;

app/lib/common/providers/notifiers/space_notifiers.dart

@@ -2,10 +2,10 @@ import 'dart:async';
 
 import 'package:acter/features/home/providers/client_providers.dart';
 import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
-import 'package:riverpod/riverpod.dart';
 import 'package:logging/logging.dart';
+import 'package:riverpod/riverpod.dart';
 
-final _log = Logger('a3::common::space');
+final _log = Logger('a3::common::space_notifiers');
 
 class AsyncMaybeSpaceNotifier extends FamilyAsyncNotifier<Space?, String> {
   late Stream<bool> _listener;

app/lib/common/utils/utils.dart

@@ -3,6 +3,7 @@
 import 'dart:async';
 import 'dart:convert';
 import 'dart:math';
+
 import 'package:acter/common/providers/room_providers.dart';
 import 'package:acter/common/utils/routes.dart';
 import 'package:acter_flutter_sdk/acter_flutter_sdk.dart';
@@ -13,9 +14,9 @@ import 'package:flutter_chat_types/flutter_chat_types.dart' as types;
 import 'package:flutter_easyloading/flutter_easyloading.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:go_router/go_router.dart';
 import 'package:intl/intl.dart';
 import 'package:jiffy/jiffy.dart';
-import 'package:go_router/go_router.dart';
 import 'package:logging/logging.dart';
 import 'package:url_launcher/url_launcher.dart';
 

app/lib/common/widgets/chat/edit_room_description_sheet.dart

@@ -3,11 +3,11 @@ import 'package:acter/common/providers/room_providers.dart';
 import 'package:acter/common/toolkit/buttons/primary_action_button.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_easyloading/flutter_easyloading.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:logging/logging.dart';
 
-final _log = Logger('a3::chat::room_description_edit_sheet');
+final _log = Logger('a3::common::chat::room_description');
 
 void showEditRoomDescriptionBottomSheet({
   required BuildContext context,

app/lib/common/widgets/event/event_selector_drawer.dart

@@ -3,7 +3,11 @@ import 'package:acter/features/events/widgets/event_item.dart';
 import 'package:acter/features/events/widgets/skeletons/event_list_skeleton_widget.dart';
 import 'package:atlas_icons/atlas_icons.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:logging/logging.dart';
+
+final _log = Logger('a3::common::cal_event::select_drawer');
 
 const Key selectEventDrawerKey = Key('event-widgets-select-event-drawer');
 
@@ -56,28 +60,28 @@ Future<String?> selectEventDrawer({
                       : ListView.builder(
                           padding: const EdgeInsets.all(8),
                           itemCount: eventsList.length,
-                          itemBuilder: (context, index) {
-                            final event = eventsList[index];
-                            return EventItem(
-                              event: event,
-                              isShowRsvp: false,
-                              onTapEventItem: (event) {
-                                Navigator.pop(context, event);
-                              },
-                            );
-                          },
+                          itemBuilder: (context, index) => EventItem(
+                            event: eventsList[index],
+                            isShowRsvp: false,
+                            onTapEventItem: (event) {
+                              Navigator.pop(context, event);
+                            },
+                          ),
                         ),
                 ),
               ],
             );
           },
           error: (error, stack) {
+            _log.severe('Failed to load all cal events', error, stack);
             return Center(
-              child: Text('Failed to load: $error'),
+              child: Text(L10n.of(context).failedToLoadEventsDueTo(error)),
             );
           },
-          loading: () =>
-              const SizedBox(height: 500, child: EventListSkeleton()),
+          loading: () => const SizedBox(
+            height: 500,
+            child: EventListSkeleton(),
+          ),
         );
       },
     ),

app/lib/common/widgets/image_dialog.dart

@@ -1,10 +1,8 @@
 import 'dart:io';
-import 'package:acter/common/themes/app_theme.dart';
-import 'package:acter/common/widgets/download_button.dart';
+import 'package:acter/features/files/widgets/share_file_button.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
-import 'package:share_plus/share_plus.dart';
 import 'package:zoom_hover_pinch_image/zoom_hover_pinch_image.dart';
 
 class ImageDialog extends ConsumerWidget {
@@ -19,7 +17,6 @@ class ImageDialog extends ConsumerWidget {
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
-    final canShare = !isDesktop;
     return Dialog(
       insetPadding: EdgeInsets.zero,
       child: Scaffold(
@@ -32,14 +29,7 @@ class ImageDialog extends ConsumerWidget {
             overflow: TextOverflow.ellipsis,
           ),
           actions: [
-            if (canShare)
-              IconButton(
-                onPressed: () {
-                  Share.shareXFiles([XFile(imageFile.path)]);
-                },
-                icon: const Icon(Icons.share),
-              ),
-            DownloadButton(file: imageFile),
+            ShareFileButton(file: imageFile),
             IconButton(
               onPressed: () => Navigator.pop(context),
               icon: const Icon(Icons.close),

app/lib/common/widgets/room/select_room_drawer.dart

@@ -1,14 +1,16 @@
 import 'package:acter/common/providers/chat_providers.dart';
 import 'package:acter/common/providers/room_providers.dart';
 import 'package:acter/common/providers/space_providers.dart';
-
 import 'package:acter/common/widgets/room/brief_room_list_entry.dart';
 import 'package:acter_avatar/acter_avatar.dart';
 import 'package:atlas_icons/atlas_icons.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:logging/logging.dart';
 import 'package:path/path.dart';
-import 'package:flutter_gen/gen_l10n/l10n.dart';
+
+final _log = Logger('a3::common::room::select_drawer');
 
 // ChildRoomType configures the sub child type of the `Spaces`
 enum RoomType {
@@ -143,14 +145,14 @@ class _SelectRoomDrawerState extends ConsumerState<SelectRoomDrawer> {
 
 //Show space list based on the search term
   Widget searchedRoomsList(BuildContext context) {
-    final searchedrooms = ref.watch(
+    final searched = ref.watch(
       switch (widget.roomType) {
         RoomType.space => searchedSpacesProvider,
         RoomType.groupChat => roomSearchedChatsProvider,
       },
     );
 
-    return searchedrooms.when(
+    return searched.when(
       data: (rooms) {
         if (rooms.isEmpty) {
           return Center(
@@ -164,7 +166,12 @@ class _SelectRoomDrawerState extends ConsumerState<SelectRoomDrawer> {
         heightFactor: 10,
         child: CircularProgressIndicator(),
       ),
-      error: (e, s) => Center(child: Text(L10n.of(context).searchingFailed(e))),
+      error: (e, s) {
+        _log.severe('Failed to search space or convo', e, s);
+        return Center(
+          child: Text(L10n.of(context).searchingFailed(e)),
+        );
+      },
     );
   }