[IMP] shopflor/mobile/_packing: Allows to select package types for packing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
force-pushed
the
16.0-imp-packing-dro
branch
3 times, most recently
from
fc10d87 to
8f5146b
Compare
rousseldenis
force-pushed
the
16.0-imp-packing-dro
branch
from
8f5146b to
11fc8dc
Compare
jbaudoux
reviewed
Jan 6, 2025
Comment on lines
+11
to
+13
| class PackagingAction(Component): | ||
|
|
||
| _inherit = "shopfloor.packaging.action" |
There was a problem hiding this comment.
Just to not confuse with product packaging
Suggested change
| class PackagingAction(Component): | |
| _inherit = "shopfloor.packaging.action" | |
| class PackAction(Component): | |
| _inherit = "shopfloor.pack.action" |
jbaudoux
reviewed
Jan 6, 2025
| _inherit = "shopfloor.cluster.picking" | ||
|
|
||
| def _get_available_delivery_packaging(self, picking): |
There was a problem hiding this comment.
Suggested change
| def _get_available_delivery_packaging(self, picking): | |
| def _get_available_delivery_package_types(self, picking): |
Comment on lines
+35
to
+41
| def list_delivery_packaging(self, picking_batch_id, picking_id, selected_line_ids): | ||
| """List available delivery packaging for given picking. | ||
|
|
||
| Transitions: | ||
| * select_delivery_packaging: list available delivery packaging, the | ||
| user has to choose one to create the new package | ||
| * select_package: when no delivery packaging is available |
There was a problem hiding this comment.
Suggested change
| def list_delivery_packaging(self, picking_batch_id, picking_id, selected_line_ids): | |
| """List available delivery packaging for given picking. | |
| Transitions: | |
| * select_delivery_packaging: list available delivery packaging, the | |
| user has to choose one to create the new package | |
| * select_package: when no delivery packaging is available | |
| def list_delivery_package_types(self, picking_batch_id, picking_id, selected_line_ids): | |
| """List available delivery package types for given picking. | |
| Transitions: | |
| * select_delivery_package_type: list available delivery package types, the | |
| user has to choose one to create the new package | |
| * select_package: when no delivery package types are available |
Comment on lines
+48
to
+49
| delivery_packaging = self._get_available_delivery_packaging(picking) | ||
| if not delivery_packaging: |
There was a problem hiding this comment.
Suggested change
| delivery_packaging = self._get_available_delivery_packaging(picking) | |
| if not delivery_packaging: | |
| delivery_package_types = self._get_available_delivery_package_types(picking) | |
| if not delivery_package_types: |
| response = self._check_allowed_qty_done(picking, selected_lines) | ||
| if response: | ||
| return response | ||
| return self._response_for_select_delivery_packaging(picking, delivery_packaging) |
There was a problem hiding this comment.
Is there a _select somewhere ?
Suggested change
| return self._response_for_select_delivery_packaging(picking, delivery_packaging) | |
| return self._response_for_select_delivery_package_type(picking, delivery_package_type) |
| When a lot is scanned, it does the same as for the products but based | ||
| on the lot. | ||
|
|
||
| When a packaging type (one without related product) is scanned, a new |
There was a problem hiding this comment.
model changed from v14, not related to product anymore
Suggested change
| When a packaging type (one without related product) is scanned, a new | |
| When a package type is scanned, a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on :