[PFP-698] Rename latest branch #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshbansal
reviewed
Dec 13, 2023
noggi
force-pushed
the
ak--rename-latest-branch
branch
from
dbf1d5b
to
7793f81
Compare
david-leifker
approved these changes
Dec 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
RUN addgroup --system datahub && adduser --system datahub --ingroup datahub
This step has already been done in datahub-ingestion-base dockerfile, it might have a conflict when building this image
noggi
force-pushed
the
ak--rename-latest-branch
branch
from
76371a1
to
281d2af
Compare
noggi
force-pushed
the
ak--rename-latest-branch
branch
from
281d2af
to
880fbf0
Compare
|
@noggi Hello, After this merge, datahub-actions image doesn't work. I'm using standard docker compose for datahub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to datahub-project/datahub#8515 datahub-ingestion-base image was published from
docker-ingestion-base.ymlworkflow. datahub-project/datahub#8515 refactored it and merged into thedocker-unifiedworkflow.The legacy
docker-ingestion-baseworkflow had the image tag hardcoded aslatest, whereas in thedocker-unifiedworkflow the tag is set dynamically based on the git ref for current commit. On any merge to themasterbranch the tag is set tohead, however the dockerfile in datahub-actions still refers to the latest image using the old tag name.@david-leifker