fix(ingest/oracle): fix scheme for sqlalchemy < 2 (datahub-project#11829

)
acrylJonny · Nov 14, 2024 · 383a70a · 383a70a
1 parent 62bb5d7
commit 383a70a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/oracle.py b/metadata-ingestion/src/datahub/ingestion/source/sql/oracle.py
@@ -63,9 +63,9 @@ def before_cursor_execute(conn, cursor, statement, parameters, context, executem
 
 
 class OracleConfig(BasicSQLAlchemyConfig):
-    # defaults
+    # TODO: Change scheme to oracle+oracledb when sqlalchemy>=2 is supported
     scheme: str = Field(
-        default="oracle+oracledb",
+        default="oracle",
         description="Will be set automatically to default value.",
     )
     service_name: Optional[str] = Field(

diff --git a/metadata-ingestion/tests/unit/test_oracle_source.py b/metadata-ingestion/tests/unit/test_oracle_source.py
@@ -21,7 +21,7 @@ def test_oracle_config():
     )
     assert (
         config.get_sql_alchemy_url()
-        == "oracle+oracledb://user:password@host:1521/?service_name=svc01"
+        == "oracle://user:password@host:1521/?service_name=svc01"
     )
 
     with pytest.raises(ValueError):