Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-2753 : CS Wizard updated node version select values #1764

Closed
wants to merge 1 commit into from

Conversation

PrakharJainS3
Copy link
Contributor

Motivation

The current values provided in NODE_VERSION need to be update as for better onboarding flow to user on Node Project. Also the default value for the select needed to be changed.

Testing steps

Following steps can be taken to verify the changes:

  • Run the following command acli cs:wizard.
  • Please enter Cloud Key and Secret to login
  • Select Node_project in project type.
  • In next select, the updated values will be visible for NODE version selection

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (a845434) to head (5d215b3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1764   +/-   ##
=========================================
  Coverage     91.75%   91.75%           
  Complexity     1818     1818           
=========================================
  Files           121      121           
  Lines          6524     6524           
=========================================
  Hits           5986     5986           
  Misses          538      538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1764/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1764/acli.phar
chmod +x acli.phar

@anavarre
Copy link
Contributor

anavarre commented Jul 8, 2024

Typically, Node versions are updated quite frequently upstream. It means you're gonna have to change the versions in ACLI equally often and get a new release out accordingly. Do we not have something more sustainable with less toil to envision?

@PrakharJainS3
Copy link
Contributor Author

PrakharJainS3 commented Jul 8, 2024

That is what we are aiming for using these changes. So previously we had minor as well as patch version selected by user in the CLI, but now we will only provide the option to select the major version which changes in a long time. We will manage the precise version to be selected by us in the background that can be changed by the user later if needed.

@anavarre
Copy link
Contributor

anavarre commented Jul 8, 2024

Believe it or not, I actually looked at the diff the other way around. All good!

@danepowell
Copy link
Contributor

Looks good except for the failing mutation test. It's telling you that tests still pass when Node 18 is removed from the available options. Looks like you need to add/improve the test for Node 18.

@danepowell
Copy link
Contributor

Note that the coding standards on this project changed dramatically since you opened this PR. You'll need to rebase or merge on master, and it might be easier to just start a new PR.

@PrakharJainS3
Copy link
Contributor Author

Will open a new PR.

@PrakharJainS3 PrakharJainS3 deleted the GL-2753 branch July 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants