CLI-1181: [pull:code] disable scripts for build branches (#1614)

* CLI-1181: [pull:code] disable scripts for build branches * add tests
acquia · Oct 26, 2023 · 229162d · 229162d
1 parent 7ccc649
commit 229162d
Show file tree

Hide file tree

Showing 2 changed files with 137 additions and 6 deletions.
diff --git a/src/Command/Pull/PullCommandBase.php b/src/Command/Pull/PullCommandBase.php
@@ -507,14 +507,21 @@ private function promptChooseDatabases(
   }
 
   protected function runComposerScripts(callable $outputCallback = NULL): void {
-    if (file_exists($this->dir . '/composer.json') && $this->localMachineHelper->commandExists('composer')) {
-      $this->checklist->addItem("Installing Composer dependencies");
-      $this->composerInstall($outputCallback);
-      $this->checklist->completePreviousItem();
+    if (!file_exists(Path::join($this->dir, 'composer.json'))) {
+      $this->io->note('composer.json file not found. Skipping composer install.');
+      return;
     }
-    else {
-      $this->logger->notice('composer or composer.json file not found. Skipping composer install.');
+    if (!$this->localMachineHelper->commandExists('composer')) {
+      $this->io->note('Composer not found. Skipping composer install.');
+      return;
     }
+    if (file_exists(Path::join($this->dir, 'vendor'))) {
+      $this->io->note('Composer dependencies already installed. Skipping composer install.');
+      return;
+    }
+    $this->checklist->addItem("Installing Composer dependencies");
+    $this->composerInstall($outputCallback);
+    $this->checklist->completePreviousItem();
   }
 
   private function determineSite(string|\AcquiaCloudApi\Response\EnvironmentResponse|array $environment, InputInterface $input): mixed {

diff --git a/tests/phpunit/src/Commands/Pull/PullCodeCommandTest.php b/tests/phpunit/src/Commands/Pull/PullCodeCommandTest.php
@@ -145,6 +145,130 @@ public function testWithScripts(): void {
     $this->assertStringContainsString('[0] Dev, dev (vcs: master)', $output);
   }
 
+  public function testNoComposerJson(): void {
+    $applicationsResponse = $this->mockApplicationsRequest();
+    $this->mockApplicationRequest();
+    $environmentsResponse = $this->mockEnvironmentsRequest($applicationsResponse);
+    $selectedEnvironment = $environmentsResponse->_embedded->items[0];
+    $this->createMockGitConfigFile();
+
+    $localMachineHelper = $this->mockReadIdePhpVersion();
+    $localMachineHelper->checkRequiredBinariesExist(["git"])->shouldBeCalled();
+    $finder = $this->mockFinder();
+    $localMachineHelper->getFinder()->willReturn($finder->reveal());
+    $this->command->localMachineHelper = $localMachineHelper->reveal();
+
+    $process = $this->mockProcess();
+    $this->mockExecuteGitFetchAndCheckout($localMachineHelper, $process, $this->projectDir, $selectedEnvironment->vcs->path);
+    $this->mockExecuteGitStatus(FALSE, $localMachineHelper, $this->projectDir);
+    $process = $this->mockProcess();
+    $this->mockExecuteDrushExists($localMachineHelper);
+    $this->mockExecuteDrushStatus($localMachineHelper, TRUE, $this->projectDir);
+    $this->mockExecuteDrushCacheRebuild($localMachineHelper, $process);
+
+    $inputs = [
+      // Would you like Acquia CLI to search for a Cloud application that matches your local git config?
+      'n',
+      // Select a Cloud Platform application:
+      0,
+      // Would you like to link the project at ... ?
+      'n',
+      // Choose an Acquia environment:
+      0,
+    ];
+
+    $this->executeCommand([], $inputs);
+    $this->prophet->checkPredictions();
+    $output = $this->getDisplay();
+    $this->assertStringContainsString('composer.json file not found. Skipping composer install.', $output);
+  }
+
+  public function testNoComposer(): void {
+    touch(Path::join($this->projectDir, 'composer.json'));
+    $applicationsResponse = $this->mockApplicationsRequest();
+    $this->mockApplicationRequest();
+    $environmentsResponse = $this->mockEnvironmentsRequest($applicationsResponse);
+    $selectedEnvironment = $environmentsResponse->_embedded->items[0];
+    $this->createMockGitConfigFile();
+
+    $localMachineHelper = $this->mockReadIdePhpVersion();
+    $localMachineHelper->checkRequiredBinariesExist(["git"])->shouldBeCalled();
+    $finder = $this->mockFinder();
+    $localMachineHelper->getFinder()->willReturn($finder->reveal());
+    $this->command->localMachineHelper = $localMachineHelper->reveal();
+
+    $process = $this->mockProcess();
+    $this->mockExecuteGitFetchAndCheckout($localMachineHelper, $process, $this->projectDir, $selectedEnvironment->vcs->path);
+    $this->mockExecuteGitStatus(FALSE, $localMachineHelper, $this->projectDir);
+    $process = $this->mockProcess();
+    $localMachineHelper
+      ->commandExists('composer')
+      ->willReturn(FALSE)
+      ->shouldBeCalled();
+    $this->mockExecuteDrushExists($localMachineHelper);
+    $this->mockExecuteDrushStatus($localMachineHelper, TRUE, $this->projectDir);
+    $this->mockExecuteDrushCacheRebuild($localMachineHelper, $process);
+
+    $inputs = [
+      // Would you like Acquia CLI to search for a Cloud application that matches your local git config?
+      'n',
+      // Select a Cloud Platform application:
+      0,
+      // Would you like to link the project at ... ?
+      'n',
+      // Choose an Acquia environment:
+      0,
+    ];
+
+    $this->executeCommand([], $inputs);
+    $this->prophet->checkPredictions();
+    $output = $this->getDisplay();
+
+    $this->assertStringContainsString('Composer not found. Skipping composer install.', $output);
+  }
+
+  public function testWithVendorDir(): void {
+    touch(Path::join($this->projectDir, 'composer.json'));
+    touch(Path::join($this->projectDir, 'vendor'));
+    $applicationsResponse = $this->mockApplicationsRequest();
+    $this->mockApplicationRequest();
+    $environmentsResponse = $this->mockEnvironmentsRequest($applicationsResponse);
+    $selectedEnvironment = $environmentsResponse->_embedded->items[0];
+    $this->createMockGitConfigFile();
+
+    $localMachineHelper = $this->mockReadIdePhpVersion();
+    $localMachineHelper->checkRequiredBinariesExist(["git"])->shouldBeCalled();
+    $finder = $this->mockFinder();
+    $localMachineHelper->getFinder()->willReturn($finder->reveal());
+    $this->command->localMachineHelper = $localMachineHelper->reveal();
+
+    $process = $this->mockProcess();
+    $this->mockExecuteGitFetchAndCheckout($localMachineHelper, $process, $this->projectDir, $selectedEnvironment->vcs->path);
+    $this->mockExecuteGitStatus(FALSE, $localMachineHelper, $this->projectDir);
+    $process = $this->mockProcess();
+    $this->mockExecuteComposerExists($localMachineHelper);
+    $this->mockExecuteDrushExists($localMachineHelper);
+    $this->mockExecuteDrushStatus($localMachineHelper, TRUE, $this->projectDir);
+    $this->mockExecuteDrushCacheRebuild($localMachineHelper, $process);
+
+    $inputs = [
+      // Would you like Acquia CLI to search for a Cloud application that matches your local git config?
+      'n',
+      // Select a Cloud Platform application:
+      0,
+      // Would you like to link the project at ... ?
+      'n',
+      // Choose an Acquia environment:
+      0,
+    ];
+
+    $this->executeCommand([], $inputs);
+    $this->prophet->checkPredictions();
+    $output = $this->getDisplay();
+
+    $this->assertStringContainsString('Composer dependencies already installed. Skipping composer install.', $output);
+  }
+
   /**
    * @return string[][]
    */