Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Gallery Store Images: Add cart backwards compatibility + default images #628

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Multiple Gallery Store Images: Add cart backwards compatibility + default images #628

merged 1 commit into from
Jan 1, 2024

Conversation

alexzhang1618
Copy link
Contributor

  • Fixing bug where store order item images weren't showing properly
  • Adding backwards compatibility for old carts containing items before the MGSI migration
    • Accepts a picture if it's defined in the cart
    • More type-safety for merchOrders
    • Also returns a default image if none of those things work

@github-actions github-actions bot added the PR: Needs Review This PR needs review label Jan 1, 2024
farisashai
farisashai approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

steets250
steets250 approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@steets250 steets250 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the deploy preview and no longer seeing an error with the cart 👍

@alexzhang1618 alexzhang1618 merged commit bc0c010 into master Jan 1, 2024
8 checks passed
@alexzhang1618 alexzhang1618 deleted the mgsi-fix branch January 1, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farisashai farisashai farisashai approved these changes

@steets250 steets250 steets250 approved these changes

@raymosun raymosun Awaiting requested review from raymosun

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7

Assignees

@alexzhang1618 alexzhang1618

Labels
PR: Needs Review This PR needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexzhang1618 @steets250 @farisashai